shafik added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.h:117
+ // (CU, (DIE)nullptr) == (nullptr, nullptr) -> true
+ if (!m_die.IsValid() && !it.m_die.IsValid())
+ return true;
----------------
I think:
```
bool operator==(const DWARFBaseDIE &lhs, const DWARFBaseDIE &rhs) {
return lhs.GetDIE() == rhs.GetDIE() && lhs.GetCU() == rhs.GetCU();
}
```
will do the same thing but maybe I am confused.
Maybe we should have a unit test?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103172/new/
https://reviews.llvm.org/D103172
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
