teemperor created this revision. teemperor added a reviewer: jankratochvil. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits.
This function was added in D67589 <https://reviews.llvm.org/D67589> and returns an internal CommandReturnObject which isn't allowed in the SB API. This patch just makes it private as all uses of this function are inside SBCommandReturnObject. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103390 Files: lldb/include/lldb/API/SBCommandReturnObject.h Index: lldb/include/lldb/API/SBCommandReturnObject.h =================================================================== --- lldb/include/lldb/API/SBCommandReturnObject.h +++ lldb/include/lldb/API/SBCommandReturnObject.h @@ -105,9 +105,6 @@ void SetError(const char *error_cstr); - // ref() is internal for LLDB only. - lldb_private::CommandReturnObject &ref() const; - protected: friend class SBCommandInterpreter; friend class SBOptions; @@ -119,6 +116,8 @@ lldb_private::CommandReturnObject &operator*() const; private: + lldb_private::CommandReturnObject &ref() const; + std::unique_ptr<lldb_private::SBCommandReturnObjectImpl> m_opaque_up; };
Index: lldb/include/lldb/API/SBCommandReturnObject.h =================================================================== --- lldb/include/lldb/API/SBCommandReturnObject.h +++ lldb/include/lldb/API/SBCommandReturnObject.h @@ -105,9 +105,6 @@ void SetError(const char *error_cstr); - // ref() is internal for LLDB only. - lldb_private::CommandReturnObject &ref() const; - protected: friend class SBCommandInterpreter; friend class SBOptions; @@ -119,6 +116,8 @@ lldb_private::CommandReturnObject &operator*() const; private: + lldb_private::CommandReturnObject &ref() const; + std::unique_ptr<lldb_private::SBCommandReturnObjectImpl> m_opaque_up; };
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
