shafik added inline comments.
================ Comment at: lldb/include/lldb/Interpreter/CommandReturnObject.h:169 + /// as a temporary. + bool m_hermetic; }; ---------------- JDevlieghere wrote: > aprantl wrote: > > bool m_hermetic = false; > This is the second time someone has suggested to use in-class member > initializers. It's not what we've been doing in LLDB so far, but I am a fan > of it personally, so I'm going to interpret this as what we want to do moving > forward. I believe it's even a C++ core guideline. Maybe we can have a clang > tidy check to enforce this. This is idiomatic C++ and we should be using this feature going forward. It is more readable then a crowded `mem-init-list` and really makes a big difference when there are multiple constructors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103349/new/ https://reviews.llvm.org/D103349 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
