dblaikie added a comment. In D101921#2786245 <https://reviews.llvm.org/D101921#2786245>, @MaskRay wrote:
> Because of `new MCObjectFileInfo`, we cannot use a forward declaration > (incomplete class) to replace `#include "llvm/MC/MCObjectFileInfo.h"` in > `TargetRegistry.h`. > > I thought about moving `TargetRegistry.{h,cpp}` from Support to Target. > However, it doesn't work because Bitcode/Object call > `TargetRegistry::lookupTarget` and Bitcode/Object are lower than Target. > > @compnerd @dblaikie @mehdi_amini Do you have suggestions on fixing the > layering? Looks like a big patch and a bit hard for me to page in all the context. Could you summarize the layering constraints/what headers/types/functions are in which libraries and why they are there/what constrains them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101921/new/ https://reviews.llvm.org/D101921 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits