teemperor accepted this revision.
teemperor added a comment.
This doesn't compile for me (on Linux):
In file included from
/home/teemperor/work/ci/llvm-project/lldb/unittests/Platform/PlatformAppleSimulatorTest.cpp:11:
In file included from
/home/teemperor/work/ci/llvm-project/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h:15:
/home/teemperor/work/ci/llvm-project/lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h:96:14:
error: use of undeclared identifier 'nil'
id m_dev = nil;
^
/home/teemperor/work/ci/llvm-project/lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h:132:14:
error: use of undeclared identifier 'nil'
id m_dev = nil;
^
/home/teemperor/work/ci/llvm-project/lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h:172:14:
error: use of undeclared identifier 'nil'
id m_dev = nil;
^
The `nil` is some Obj-C thing but the headers are includes from a C++ file. I
don't think we should add Obj-C includes to the header as we really need to
keep the Objective-C++ code in LLDB as small as possible, so maybe change this
to `nullptr`?
Beside that I couldn't find anything that would block this patch. There are a
bunch of additional NFC cleanups possible but that seems out of scope, so LGTM
modulo `nil -> nullptr`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103483/new/
https://reviews.llvm.org/D103483
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
