teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits.
HostInfoBase has a deleted dtor/ctor so there is no need to do the same for all the classes inheriting from it. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D104221 Files: lldb/include/lldb/Host/linux/HostInfoLinux.h lldb/include/lldb/Host/macosx/HostInfoMacOSX.h lldb/include/lldb/Host/windows/HostInfoWindows.h Index: lldb/include/lldb/Host/windows/HostInfoWindows.h =================================================================== --- lldb/include/lldb/Host/windows/HostInfoWindows.h +++ lldb/include/lldb/Host/windows/HostInfoWindows.h @@ -19,11 +19,6 @@ class HostInfoWindows : public HostInfoBase { friend class HostInfoBase; -private: - // Static class, unconstructable. - HostInfoWindows(); - ~HostInfoWindows(); - public: static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr); static void Terminate(); Index: lldb/include/lldb/Host/macosx/HostInfoMacOSX.h =================================================================== --- lldb/include/lldb/Host/macosx/HostInfoMacOSX.h +++ lldb/include/lldb/Host/macosx/HostInfoMacOSX.h @@ -21,11 +21,6 @@ class HostInfoMacOSX : public HostInfoPosix { friend class HostInfoBase; -private: - // Static class, unconstructable. - HostInfoMacOSX() = delete; - ~HostInfoMacOSX() = delete; - public: static llvm::VersionTuple GetOSVersion(); static llvm::VersionTuple GetMacCatalystVersion(); Index: lldb/include/lldb/Host/linux/HostInfoLinux.h =================================================================== --- lldb/include/lldb/Host/linux/HostInfoLinux.h +++ lldb/include/lldb/Host/linux/HostInfoLinux.h @@ -21,11 +21,6 @@ class HostInfoLinux : public HostInfoPosix { friend class HostInfoBase; -private: - // Static class, unconstructable. - HostInfoLinux(); - ~HostInfoLinux(); - public: static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr); static void Terminate();
Index: lldb/include/lldb/Host/windows/HostInfoWindows.h =================================================================== --- lldb/include/lldb/Host/windows/HostInfoWindows.h +++ lldb/include/lldb/Host/windows/HostInfoWindows.h @@ -19,11 +19,6 @@ class HostInfoWindows : public HostInfoBase { friend class HostInfoBase; -private: - // Static class, unconstructable. - HostInfoWindows(); - ~HostInfoWindows(); - public: static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr); static void Terminate(); Index: lldb/include/lldb/Host/macosx/HostInfoMacOSX.h =================================================================== --- lldb/include/lldb/Host/macosx/HostInfoMacOSX.h +++ lldb/include/lldb/Host/macosx/HostInfoMacOSX.h @@ -21,11 +21,6 @@ class HostInfoMacOSX : public HostInfoPosix { friend class HostInfoBase; -private: - // Static class, unconstructable. - HostInfoMacOSX() = delete; - ~HostInfoMacOSX() = delete; - public: static llvm::VersionTuple GetOSVersion(); static llvm::VersionTuple GetMacCatalystVersion(); Index: lldb/include/lldb/Host/linux/HostInfoLinux.h =================================================================== --- lldb/include/lldb/Host/linux/HostInfoLinux.h +++ lldb/include/lldb/Host/linux/HostInfoLinux.h @@ -21,11 +21,6 @@ class HostInfoLinux : public HostInfoPosix { friend class HostInfoBase; -private: - // Static class, unconstructable. - HostInfoLinux(); - ~HostInfoLinux(); - public: static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr); static void Terminate();
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits