aprantl added a comment.

> if the return type of the new function is not too awful to type, maybe don't 
> use auto? It says it's returning a path, which is usually a string, not a 
> FileSpec... But that's more a matter of taste.

I think that's generally advice. In this particular case, the code gets deleted 
by a subsequent patch in this stack anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104404/new/

https://reviews.llvm.org/D104404

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to