clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1308
     }
     if (FileSystem::Instance().IsDirectory(file)) {
       SetError("Not a file!");
----------------
OmarEmaraDev wrote:
> clayborg wrote:
> > This is checking for a directory, not a file
> Not sure what you mean. It is setting an error if the file was in fact a 
> directory,
Woops! You are right...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106553/new/

https://reviews.llvm.org/D106553

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to