jankratochvil added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:519 + contribution->Length); + return DWARFDataExtractor(); + } ---------------- Here could be an error message. ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:537 + if (const llvm::DWARFUnitIndex::Entry *entry = m_header.GetIndexEntry()) { + const auto *contribution = entry->getContribution(llvm::DW_SECT_RNGLISTS); + if (!contribution) { ---------------- I have found this `getContribution` adjustment duplication, are there some reasons it is not unified? https://www.jankratochvil.net/t/D107456-unify.patch The issue is the code then handles two different `.debug_rnglists` `DWARFDataExtractor`s with different offsets. ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:556 + " (ranges list base: 0x%" PRIx64 "): %s", + offset, m_ranges_base, toString(table_or_error.takeError()).c_str()); } ---------------- One such reason can be missing DWP absolute offset for the error report. That could be returned from `GetRnglistData()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107456/new/ https://reviews.llvm.org/D107456 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits