JDevlieghere added inline comments.
================ Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:148 + + std::string proc_fd_path = "/proc/self/fd"; + std::error_code EC; ---------------- MaskRay wrote: > Can this be a StringRef? ================ Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:149 + std::string proc_fd_path = "/proc/self/fd"; + std::error_code EC; + bool result; ---------------- ================ Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:155 + // Directory iterator doesn't ensure any sequence. + for (llvm::sys::fs::directory_iterator iter(proc_fd_path, EC), FileEnd; + iter != FileEnd && !EC; iter.increment(EC)) { ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits