jingham added a comment.

Raphael's analysis of what the test needs is right.  We always check pointers 
for validity before we do operations on them, so we wouldn't have tried to get 
the summary.

The reason I passed the string reference to a function and check it there is 
because from many years of experience, I don't trust compilers even at -O0 not 
to elide references to silly unused variables.  But at -O0 a function argument 
is never going away.

But if folks think this is over paranoid on my part, I can simplify the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108228/new/

https://reviews.llvm.org/D108228

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to