augusto2112 created this revision.
augusto2112 added a reviewer: aprantl.
augusto2112 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Some lldb tests are failing intermittently due to the check for simulators
failing for some reason unrelated to the test. Catch any exceptions thrown by
calling the xcodebuild subprocess invoked, report them to the user, and skip
the test
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D109004
Files:
lldb/packages/Python/lldbsuite/test/decorators.py
Index: lldb/packages/Python/lldbsuite/test/decorators.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/decorators.py
+++ lldb/packages/Python/lldbsuite/test/decorators.py
@@ -381,6 +381,8 @@
return "%s simulator is not supported on this system." %
platform
except subprocess.CalledProcessError:
return "Simulators are unsupported on this system (xcodebuild
failed)"
+ except Exception as e:
+ return "Simulator check failed with exception: %s" % e
return skipTestIfFn(should_skip_simulator_test)
Index: lldb/packages/Python/lldbsuite/test/decorators.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/decorators.py
+++ lldb/packages/Python/lldbsuite/test/decorators.py
@@ -381,6 +381,8 @@
return "%s simulator is not supported on this system." % platform
except subprocess.CalledProcessError:
return "Simulators are unsupported on this system (xcodebuild failed)"
+ except Exception as e:
+ return "Simulator check failed with exception: %s" % e
return skipTestIfFn(should_skip_simulator_test)
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
