clayborg added inline comments.

================
Comment at: 
lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py:17
+
+    @skipUnlessArch("x86_64")
+    @skipUnlessPlatform(["linux"])
----------------
Do we only support x86_64 right now? If we are actually supporting other 
architectures and emitting a minidump for them, we should be testing them. Do 
we return an error for any architectures that we don't support in the 
ObjectFIleMinidump::SaveCore(...) function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108233/new/

https://reviews.llvm.org/D108233

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to