[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: 
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:776
+
+  std::array<char, 64> data;
+  DataEncoder encoder{data.data(), data.size(), lldb::eByteOrderBig,
----------------
consider:
```
struct GdbStat {
  llvm::support::ubig32_t st_dev;
  llvm::support::ubig32_t st_ino;
  ...
};

...

translate(gdb_stats.st_dev, file_stats.st_dev, 0); // I'm not sure that this 
clamping is really necessary.
...
```

Seems like it could be nicer, particularly as the vFile_Stat function will need 
to do the same thing...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107840/new/

https://reviews.llvm.org/D107840

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits