thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Very cool. LG with top-level BUILD.gn comment addressed :)



================
Comment at: llvm/utils/gn/secondary/BUILD.gn:15
     "//lld/test",
+    "//lldb",
     "//llvm/test",
----------------
Does this build fine on windows?

Generally this only depends on the test targets which in turn depend on the 
binaries, so probably should only have the old/test dep in this file anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109463/new/

https://reviews.llvm.org/D109463

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to