labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
LG, modulo the comment. Keep an eye out on the bots though. I fear some systems (windows, in particular), may not have all errno constants defined, and we'll need to do something smarter. ================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3075 +#include "Plugins/Process/gdb-remote/GDBRemoteErrno.def" +#undef HANDLE_ERRNO + default: ---------------- Normally, it's the job of the .def file to undef this macro. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108148/new/ https://reviews.llvm.org/D108148 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
