calebzulawski created this revision. calebzulawski added a reviewer: wallace. calebzulawski added a project: LLDB. Herald added a subscriber: JDevlieghere. calebzulawski requested review of this revision. Herald added a subscriber: lldb-commits.
Usage of aux_size is guarded against elsewhere in this file, but is missing here. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110269 Files: lldb/source/Plugins/Process/Linux/IntelPTManager.cpp Index: lldb/source/Plugins/Process/Linux/IntelPTManager.cpp =================================================================== --- lldb/source/Plugins/Process/Linux/IntelPTManager.cpp +++ lldb/source/Plugins/Process/Linux/IntelPTManager.cpp @@ -145,7 +145,11 @@ } size_t IntelPTThreadTrace::GetTraceBufferSize() const { +#ifndef PERF_ATTR_SIZE_VER5 + llvm_unreachable("Intel PT Linux perf event not supported"); +#else return m_mmap_meta->aux_size; +#endif } static Expected<uint64_t>
Index: lldb/source/Plugins/Process/Linux/IntelPTManager.cpp =================================================================== --- lldb/source/Plugins/Process/Linux/IntelPTManager.cpp +++ lldb/source/Plugins/Process/Linux/IntelPTManager.cpp @@ -145,7 +145,11 @@ } size_t IntelPTThreadTrace::GetTraceBufferSize() const { +#ifndef PERF_ATTR_SIZE_VER5 + llvm_unreachable("Intel PT Linux perf event not supported"); +#else return m_mmap_meta->aux_size; +#endif } static Expected<uint64_t>
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits