[Lldb-commits] [PATCH] D110510: [lldb] Remove "0x" prefix from hex values in dirty-pages

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: labath, krytarowski, emaste, JDevlieghere, teemperor.
mgorny requested review of this revision.

Remove the redudant "0x" prefix in the "dirty-pages" key of
qMemoryRegionInfo packet.  The client accepts hex values both with
and without the prefix.


https://reviews.llvm.org/D110510

Files:
  lldb/test/API/functionalities/gdb_remote_client/TestMemoryRegionDirtyPages.py
  lldb/tools/debugserver/source/RNBRemote.cpp


Index: lldb/tools/debugserver/source/RNBRemote.cpp
===================================================================
--- lldb/tools/debugserver/source/RNBRemote.cpp
+++ lldb/tools/debugserver/source/RNBRemote.cpp
@@ -4306,7 +4306,7 @@
         if (!first)
           ostrm << ",";
         first = false;
-        ostrm << "0x" << std::hex << addr;
+        ostrm << std::hex << addr;
       }
     }
     ostrm << ";";
Index: 
lldb/test/API/functionalities/gdb_remote_client/TestMemoryRegionDirtyPages.py
===================================================================
--- 
lldb/test/API/functionalities/gdb_remote_client/TestMemoryRegionDirtyPages.py
+++ 
lldb/test/API/functionalities/gdb_remote_client/TestMemoryRegionDirtyPages.py
@@ -19,9 +19,9 @@
                 if addr == 0x100000000:
                     return 
"start:100000000;size:4000;permissions:rx;dirty-pages:;"
                 if addr == 0x100004000:
-                    return 
"start:100004000;size:4000;permissions:r;dirty-pages:0x100004000;"
+                    return 
"start:100004000;size:4000;permissions:r;dirty-pages:100004000;"
                 if addr == 0x1000a2000:
-                    return 
"start:1000a2000;size:5000;permissions:r;dirty-pages:0x1000a2000,0x1000a3000,0x1000a4000,0x1000a5000,0x1000a6000;"
+                    return 
"start:1000a2000;size:5000;permissions:r;dirty-pages:1000a2000,1000a3000,1000a4000,1000a5000,1000a6000;"
 
         self.server.responder = MyResponder()
         target = self.dbg.CreateTarget('')



Index: lldb/tools/debugserver/source/RNBRemote.cpp
===================================================================
--- lldb/tools/debugserver/source/RNBRemote.cpp
+++ lldb/tools/debugserver/source/RNBRemote.cpp
@@ -4306,7 +4306,7 @@
         if (!first)
           ostrm << ",";
         first = false;
-        ostrm << "0x" << std::hex << addr;
+        ostrm << std::hex << addr;
       }
     }
     ostrm << ";";
Index: lldb/test/API/functionalities/gdb_remote_client/TestMemoryRegionDirtyPages.py
===================================================================
--- lldb/test/API/functionalities/gdb_remote_client/TestMemoryRegionDirtyPages.py
+++ lldb/test/API/functionalities/gdb_remote_client/TestMemoryRegionDirtyPages.py
@@ -19,9 +19,9 @@
                 if addr == 0x100000000:
                     return "start:100000000;size:4000;permissions:rx;dirty-pages:;"
                 if addr == 0x100004000:
-                    return "start:100004000;size:4000;permissions:r;dirty-pages:0x100004000;"
+                    return "start:100004000;size:4000;permissions:r;dirty-pages:100004000;"
                 if addr == 0x1000a2000:
-                    return "start:1000a2000;size:5000;permissions:r;dirty-pages:0x1000a2000,0x1000a3000,0x1000a4000,0x1000a5000,0x1000a6000;"
+                    return "start:1000a2000;size:5000;permissions:r;dirty-pages:1000a2000,1000a3000,1000a4000,1000a5000,1000a6000;"
 
         self.server.responder = MyResponder()
         target = self.dbg.CreateTarget('')

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits