clayborg added a comment.
This looks good to me. Pavel, are you ok with the testing strategy with the
updated tests?
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3630-3631
+ if (tag == DW_TAG_inlined_subroutine) {
+ // Walk abstract origins until we find DW_TAG_subprogram and extract
+ // its formal parameters.
+ DWARFDIE abs_die = die;
----------------
Maybe expand this comment a bit. If I understand the problem correctly it might
read something like:
```
DW_TAG_inline_subroutine objects may omit DW_TAG_formal_parameter in instances
of the function when they are unused or ... . The current
DW_TAG_inline_subroutine may refer to another DW_TAG_inline_subroutine or
DW_TAG_subprogram that might actually have the definitions of the parameters
and we need to include these so they show up in the variables for this function.
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110571/new/
https://reviews.llvm.org/D110571
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
