teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
LGTM, but maybe give the test comment a FIXME. ================ Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:39 + //% self.expect_var_path('constcharstar', summary='"Hello\t\tWorld\nI am here\t\tto say hello\n"') //% self.assertTrue(self.frame().FindVariable('longstring').GetSummary().endswith('"...')) //% self.assertTrue(self.frame().FindVariable('longconstcharstar').GetSummary().endswith('"...')) ---------------- If you align the start of these comments when merging this, then I'll address you from now on as "Pavel the Great". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111399/new/ https://reviews.llvm.org/D111399 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits