teemperor added reviewers: mstorsjo, rnk. teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere.
This looks in general good to me. You probably want to add a test for this (`llvm/test/Demangle/ms-options.test` seems like the right place). I added some folks to review the Demangler changes. The LLDB itself LGTM, but it seems like this patch is also clang-formatting some lines that are unrelated to this patch, so please just clang-format those files as a preparatory NFC commit (If you don't have commit access then @werat or me can also just do that quickly for you). FWIW, there is a git clang-format script that limits clang-format changes to just the lines you touched. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111715/new/ https://reviews.llvm.org/D111715 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
