[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/source/Host/common/Terminal.cpp:76
+  struct termios &fd_termios = data->m_termios;
+  bool set_corectly = false;
+  if (enabled) {
----------------
My gut feeling is telling me that this can be simplified somehow… or we could 
assume `tcsetattr()` is cheap and just do the change unconditionally.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111890/new/

https://reviews.llvm.org/D111890

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits