This revision was automatically updated to reflect the committed changes. Closed by commit rG239b4d62b6c0: [lldb] [Utility] Remove Status::WasInterrupted() along with its only use (authored by mgorny). Herald added a project: LLDB.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111908/new/ https://reviews.llvm.org/D111908 Files: lldb/include/lldb/Utility/Status.h lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source/Utility/Status.cpp Index: lldb/source/Utility/Status.cpp =================================================================== --- lldb/source/Utility/Status.cpp +++ lldb/source/Utility/Status.cpp @@ -287,10 +287,6 @@ // return value. bool Status::Success() const { return m_code == 0; } -bool Status::WasInterrupted() const { - return (m_type == eErrorTypePOSIX && m_code == EINTR); -} - void llvm::format_provider<lldb_private::Status>::format( const lldb_private::Status &error, llvm::raw_ostream &OS, llvm::StringRef Options) { Index: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp =================================================================== --- lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp +++ lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp @@ -872,9 +872,6 @@ if (conn_up->Connect(connect_url, &error) == eConnectionStatusSuccess) { m_gdb_comm.SetConnection(std::move(conn_up)); break; - } else if (error.WasInterrupted()) { - // If we were interrupted, don't keep retrying. - break; } retry_count++; Index: lldb/include/lldb/Utility/Status.h =================================================================== --- lldb/include/lldb/Utility/Status.h +++ lldb/include/lldb/Utility/Status.h @@ -184,16 +184,6 @@ /// success (non-erro), \b false otherwise. bool Success() const; - /// Test for a failure due to a generic interrupt. - /// - /// Returns true if the error code in this object was caused by an - /// interrupt. At present only supports Posix EINTR. - /// - /// \return - /// \b true if this object contains an value that describes - /// failure due to interrupt, \b false otherwise. - bool WasInterrupted() const; - protected: /// Member variables ValueType m_code = 0; ///< Status code as an integer value.
Index: lldb/source/Utility/Status.cpp =================================================================== --- lldb/source/Utility/Status.cpp +++ lldb/source/Utility/Status.cpp @@ -287,10 +287,6 @@ // return value. bool Status::Success() const { return m_code == 0; } -bool Status::WasInterrupted() const { - return (m_type == eErrorTypePOSIX && m_code == EINTR); -} - void llvm::format_provider<lldb_private::Status>::format( const lldb_private::Status &error, llvm::raw_ostream &OS, llvm::StringRef Options) { Index: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp =================================================================== --- lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp +++ lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp @@ -872,9 +872,6 @@ if (conn_up->Connect(connect_url, &error) == eConnectionStatusSuccess) { m_gdb_comm.SetConnection(std::move(conn_up)); break; - } else if (error.WasInterrupted()) { - // If we were interrupted, don't keep retrying. - break; } retry_count++; Index: lldb/include/lldb/Utility/Status.h =================================================================== --- lldb/include/lldb/Utility/Status.h +++ lldb/include/lldb/Utility/Status.h @@ -184,16 +184,6 @@ /// success (non-erro), \b false otherwise. bool Success() const; - /// Test for a failure due to a generic interrupt. - /// - /// Returns true if the error code in this object was caused by an - /// interrupt. At present only supports Posix EINTR. - /// - /// \return - /// \b true if this object contains an value that describes - /// failure due to interrupt, \b false otherwise. - bool WasInterrupted() const; - protected: /// Member variables ValueType m_code = 0; ///< Status code as an integer value.
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits