mgorny marked an inline comment as done. mgorny added a comment. I'm not sure what exactly you're proposing and whether your proposal would work but I think it's a step in the right direction.
Let's start by reiterating what we need: 1. A way to iterate over all subregisters of given `RegKind`, sorted by base register index, yielding base register index and subregister name (`map<RegKind, vector<...>>`. 2. A way to match register name against all *expected* subregisters in order to abort if any of them exists (`set<StringRef>`). 3. A way to match register name against all known base registers and store their indices (`map<StringRef, ...>`). 4. We should be able to construct all of the above from some readable input. ================ Comment at: lldb/source/Plugins/ABI/X86/ABIX86.cpp:171 + "xmm14", + "xmm15", + }}; ---------------- labath wrote: > For a simple list like this, I'd probably remove the trailing comma to have > clang-format format it more succinctly. Heh, I was wondering why clang-format chooses one format sometimes, and the other sometimes but it wouldn't occur to me that it's due to the trailing comma ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108937/new/ https://reviews.llvm.org/D108937 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
