Author: Michał Górny Date: 2021-10-21T10:55:02+02:00 New Revision: 4745e4178397b387263f2547e13018e3c8ee396c
URL: https://github.com/llvm/llvm-project/commit/4745e4178397b387263f2547e13018e3c8ee396c DIFF: https://github.com/llvm/llvm-project/commit/4745e4178397b387263f2547e13018e3c8ee396c.diff LOG: [lldb] [unittest] Disable SetParity() tests on Linux entirely Attempting to enable PARENB causes tcsetattr() to fail on the Debian and Ubuntu buildbots, so let's skip these tests on Linux entirely. Added: Modified: lldb/unittests/Host/posix/TerminalTest.cpp Removed: ################################################################################ diff --git a/lldb/unittests/Host/posix/TerminalTest.cpp b/lldb/unittests/Host/posix/TerminalTest.cpp index 4a81bea88d9e..0313007f89e1 100644 --- a/lldb/unittests/Host/posix/TerminalTest.cpp +++ b/lldb/unittests/Host/posix/TerminalTest.cpp @@ -143,12 +143,11 @@ TEST_F(TerminalTest, SetParity) { ASSERT_EQ(tcgetattr(m_fd, &terminfo), 0); EXPECT_EQ(terminfo.c_cflag & PARENB, 0U); +#if !defined(__linux__) // Linux pty devices do not support setting parity ASSERT_THAT_ERROR(m_term.SetParity(Terminal::Parity::Even), llvm::Succeeded()); ASSERT_EQ(tcgetattr(m_fd, &terminfo), 0); -#if !defined(__linux__) // Linux pty devices strip PARENB EXPECT_NE(terminfo.c_cflag & PARENB, 0U); -#endif EXPECT_EQ(terminfo.c_cflag & PARODD, 0U); #if defined(CMSPAR) EXPECT_EQ(terminfo.c_cflag & CMSPAR, 0U); @@ -156,9 +155,7 @@ TEST_F(TerminalTest, SetParity) { ASSERT_THAT_ERROR(m_term.SetParity(Terminal::Parity::Odd), llvm::Succeeded()); ASSERT_EQ(tcgetattr(m_fd, &terminfo), 0); -#if !defined(__linux__) // Linux pty devices strip PARENB EXPECT_NE(terminfo.c_cflag & PARENB, 0U); -#endif EXPECT_NE(terminfo.c_cflag & PARODD, 0U); #if defined(CMSPAR) EXPECT_EQ(terminfo.c_cflag & CMSPAR, 0U); @@ -168,21 +165,20 @@ TEST_F(TerminalTest, SetParity) { ASSERT_THAT_ERROR(m_term.SetParity(Terminal::Parity::Space), llvm::Succeeded()); ASSERT_EQ(tcgetattr(m_fd, &terminfo), 0); -#if !defined(__linux__) // Linux pty devices strip PARENB EXPECT_NE(terminfo.c_cflag & PARENB, 0U); -#endif EXPECT_EQ(terminfo.c_cflag & PARODD, 0U); EXPECT_NE(terminfo.c_cflag & CMSPAR, 0U); ASSERT_THAT_ERROR(m_term.SetParity(Terminal::Parity::Mark), llvm::Succeeded()); ASSERT_EQ(tcgetattr(m_fd, &terminfo), 0); -#if !defined(__linux__) // Linux pty devices strip PARENB EXPECT_NE(terminfo.c_cflag & PARENB, 0U); -#endif EXPECT_NE(terminfo.c_cflag & PARODD, 0U); EXPECT_NE(terminfo.c_cflag & CMSPAR, 0U); -#else +#endif // defined(CMSPAR) +#endif // !defined(__linux__) + +#if !defined(CMSPAR) ASSERT_THAT_ERROR(m_term.SetParity(Terminal::Parity::Space), llvm::Failed<llvm::ErrorInfoBase>(testing::Property( &llvm::ErrorInfoBase::message, _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits