shafik added a comment.

It looks good to me but can we verify it behaves nicely with undefined behavior 
cases e.g.:

  std::string s = "Hellooooooooooooooo ";
  std::string_view sv = s + "World\n";

and a case like the one that was fixed in D108228 
<https://reviews.llvm.org/D108228>

I am not expecting any surprises since you are using the underlying string 
formatter but worth checking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112222/new/

https://reviews.llvm.org/D112222

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to