[Lldb-commits] [PATCH] D112309: [lldb] [Utility/UriParser] Replace port==-1 with llvm::None

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Seems like a (slight) improvement. You don't have to do this, but what I think 
would best help here is if we made a struct for these parsed results:

  struct URI {
    static Optional<URI> parse(StringRef);
    StringRef scheme;
    ...
  }

throw in an operator== and << and even the unit tests would become nicer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112309/new/

https://reviews.llvm.org/D112309

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits