JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed.
================ Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:105 + lldb::RegisterContextSP reg_ctx_sp; + Status error; + ---------------- It looks like this error is set but never used/returned? Should this return an `Expected<RegisterContextSP>` with the caller dealing with the error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112167/new/ https://reviews.llvm.org/D112167 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
