thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: lldb/source/Host/common/Terminal.cpp:39
+
llvm::Expected<Terminal::Data> Terminal::GetData() {
if (!FileDescriptorIsValid())
----------------
nit: should GetData() even exist if `!LLDB_ENABLE_TERMIOS`? Looks like it's
only called `#if LLDB_ENABLE_TERMIOS` now. Maybe the whole method definition
should be inside an ifdef.
If it should keep existing, either move the !FileDescriptorIsValid() check into
the #if inside it (imho preferred), or move all the callers of it outside that
#if. The current mix is a bit self-inconsistent.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112632/new/
https://reviews.llvm.org/D112632
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
