This revision was automatically updated to reflect the committed changes.
Closed by commit rGac73f567cffb: [lldb] Remove forgotten FIXME on CPlusPlus
formatters (authored by ljmf00, committed by teemperor).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112586/new/
https://reviews.llvm.org/D112586
Files:
lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
Index: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
===================================================================
--- lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
+++ lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
@@ -1014,8 +1014,6 @@
.SetShowMembersOneLiner(false)
.SetHideItemNames(false);
- // FIXME because of a bug in the FormattersContainer we need to add a summary
- // for both X* and const X* (<rdar://problem/12717717>)
AddCXXSummary(
cpp_category_sp, lldb_private::formatters::Char8StringSummaryProvider,
"char8_t * summary provider", ConstString("char8_t *"), string_flags);
Index: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
===================================================================
--- lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
+++ lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
@@ -1014,8 +1014,6 @@
.SetShowMembersOneLiner(false)
.SetHideItemNames(false);
- // FIXME because of a bug in the FormattersContainer we need to add a summary
- // for both X* and const X* (<rdar://problem/12717717>)
AddCXXSummary(
cpp_category_sp, lldb_private::formatters::Char8StringSummaryProvider,
"char8_t * summary provider", ConstString("char8_t *"), string_flags);
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
