zequanwu added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:337 + std::lock_guard<std::recursive_mutex> guard(GetModuleMutex()); + if (!(name_type_mask & eFunctionNameTypeMethod)) + return; ---------------- labath wrote: > How did you come to pick this? I get that this is not critical functionality > for your use case, but it seems rather strange to be claiming that you're > looking up methods here. If you don't care what you look up exactly, then > maybe you could just skip this check completely, possibly leaving a TODO to > implement this in a better way. (The Symtab class has code (heuristics) which > tries to classify symbols into functions, methods, etc., but I'm not sure if > it actually works with breakpad symbols (them being demangled), nor am I sure > that we should replicate that here.) I just found that name_type_mask always has `eFunctionNameTypeMethod`. Removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
