zequanwu created this revision.
zequanwu added reviewers: labath, shafik.
zequanwu requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
As the deleted comment says, we don't care about the access specifier.
I also encountered a crash at here (called from
https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp#L2141)
when fixing a bug on SymbolFileNativePDB.cpp.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D113533
Files:
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
Index: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
===================================================================
--- lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -89,11 +89,6 @@
namespace {
static void VerifyDecl(clang::Decl *decl) {
assert(decl && "VerifyDecl called with nullptr?");
-#ifndef NDEBUG
- // We don't care about the actual access value here but only want to trigger
- // that Clang calls its internal Decl::AccessDeclContextSanity check.
- decl->getAccess();
-#endif
}
static inline bool
Index: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
===================================================================
--- lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -89,11 +89,6 @@
namespace {
static void VerifyDecl(clang::Decl *decl) {
assert(decl && "VerifyDecl called with nullptr?");
-#ifndef NDEBUG
- // We don't care about the actual access value here but only want to trigger
- // that Clang calls its internal Decl::AccessDeclContextSanity check.
- decl->getAccess();
-#endif
}
static inline bool
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
