jingham added inline comments.
================
Comment at: lldb/source/Target/Process.cpp:2496-2497
Module *exe_module = GetTarget().GetExecutableModulePointer();
- if (!exe_module) {
- error.SetErrorString("executable module does not exist");
- return error;
- }
-
char local_exec_file_path[PATH_MAX];
char platform_exec_file_path[PATH_MAX];
+
----------------
clayborg wrote:
> maybe switch these over to std::string values and then use the
> FileSpec::GetPath() that returns a std::string below? It would be nice to
> remove any PATH_MAX stuff from our generic code if possible.
Turns out that the remote path string wasn't used at all, and the local one was
only used for error reporting. So I deleted the one, and moved the other to
where we report the error (and used a std::string)...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113521/new/
https://reviews.llvm.org/D113521
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
