teemperor added a comment. In D113634#3124401 <https://reviews.llvm.org/D113634#3124401>, @ljmf00 wrote:
> In D113634#3124042 <https://reviews.llvm.org/D113634#3124042>, @teemperor > wrote: > >> Are the DWARFASTParserClang changes meant as a step towards making it parse >> D? > > Yes, not only D but any language that currently falls here > (https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp#L106-L112). > AFAIK, rust have immutable variables too. Since I'm working on a > DWARFFASTParser for D this won't affect it in the future, but for languages > like Rust that uses the Python API and rely on Clang DWARFParser, this could > be beneficial. I know the change is well intended, but the Rust support is 100% untested and completely broken (it can't deal with pretty much any non-trivial program from my recollections). So I would split out the Clang changes (which probably require some longer discussion) and just keep the Type/DWARFDIe changes (which look good to me). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113634/new/ https://reviews.llvm.org/D113634 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
