rnk added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1019
+ if (parent->isRecord()) {
+ struct ProcessOneMethodRecord : public TypeVisitorCallbacks {
+ ProcessOneMethodRecord(PdbIndex &m_index, TypeSystemClang &m_clang,
----------------
As a style thing, this class is quite large, I think I would prefer to see this
at global scope in an anonymous namespace.
================
Comment at: lldb/test/Shell/SymbolFile/NativePDB/find-functions.cpp:89
+// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int (void)"
+// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int (char)"
+// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int (char, int, ...)"
----------------
I guess the test isn't able to differentiate whether these methods are static,
private, etc. =/
We can overlook that for now, but I think now is the time to invest in better
testing tools. The lldb-test program can do whatever you need it to, I don't
think changing it requires updating that many tests, I think it's something you
should look into.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113930/new/
https://reviews.llvm.org/D113930
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
