clayborg added a comment. In D113650#3173914 <https://reviews.llvm.org/D113650#3173914>, @nealsid wrote:
> In D113650#3168622 <https://reviews.llvm.org/D113650#3168622>, @clayborg > wrote: > >> I can't build on macOS now. I checked out the source code and tried to do: >> >> cmake -G Ninja -DCMAKE_BUILD_TYPE:STRING=Debug >> -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE >> -DLLVM_ENABLE_PROJECTS='clang;libcxx;libcxxabi;lldb' >> -DLLDB_BUILD_FRAMEWORK:BOOL=TRUE -DLLDB_USE_SYSTEM_DEBUGSERVER=ON >> -DLLDB_EDITLINE_USE_WCHAR=0 -DLLDB_ENABLE_LIBEDIT:BOOL=TRUE >> -DLLDB_ENABLE_CURSES:BOOL=TRUE -DLLDB_ENABLE_PYTHON:BOOL=TRUE >> -DLLDB_ENABLE_LIBXML2:BOOL=TRUE -DLLDB_ENABLE_LUA:BOOL=FALSE >> ../llvm-project/llvm > > Random drive-by comment - any particular reason you compile without WCHAR > support in libedit? I have a patch that removes the conditional support from > our Editline class (actually it was committed and had to be reverted :P). But > I was under the impression that nobody was using the non-WCHAR support > anymore. Thanks. No real reason. I would be fine if this went away. Not sure if there are any platforms that have an older libedit shared library that need to avoid bugs in the wide character implementation, but I don't work on any. So feel free to remove this and see how things go! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
