sammccall added inline comments.
================ Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:995 /// \param NumCandidates the number of overload candidates void ProcessOverloadCandidates(Sema &S, unsigned CurrentArg, OverloadCandidate *Candidates, ---------------- kadircet wrote: > why not just drop the method? it is not pure, and no-op in base too. That's a reasonable question, but it's not my code so IDK if it's a style thing. (I was tempted to remove it but it seems gratuitous for this kind of change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116317/new/ https://reviews.llvm.org/D116317 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits