DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. As promised on https://reviews.llvm.org/D112824.
I hope to get to a point where the tag managers only remove memory tag bits so this is a step toward that. ================ Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1370 // is not a guarantee. - MemoryTagManager::TagRange range(details->manager->RemoveNonAddressBits(addr), - len); + MemoryTagManager::TagRange range(details->manager->RemoveTagBits(addr), len); range = details->manager->ExpandToGranule(range); ---------------- The usage in lldb-server is why I have kept it removing the whole top byte to keep us in line with: https://dri.freedesktop.org/docs/drm/arm64/tagged-address-abi.html You might wonder if we should remove non-address bits here too but going by that standard I think the answer is no. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117671/new/ https://reviews.llvm.org/D117671 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
