thakis added a comment.
> The background here is that I found this patch in one of my old WIP branches.
> The next patch in the series was going to define LLDB_API to
> `__attribute__((visibility("default")))` on the non-windows path (and make
> everything else hidden), but I have no idea why I wanted to do that. I mean,
> it does not sounds like an *un*reasonable thing to do, but am not going to do
> unless I find some benefit to it (maybe it saves size?)
It'd allow getting rid of the .exports files, which would be nice I suppose.
> Anyway, what would you say if we wrapped this entire LLDB_API-setting block
> in an `#ifndef LLDB_API`? That way, things would still work out-of-the-box in
> the default (supported) configuration, but users who know what they're doing
> can define it to visibility(default), nothing, or whatever else, and that
> would take precedence.
That sounds like a good idea to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117564/new/
https://reviews.llvm.org/D117564
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
