JDevlieghere added a comment.
In D117712#3255978 <https://reviews.llvm.org/D117712#3255978>, @labath wrote:
> It seems the set of macros could be reduced. If you don't need to generate
> "unique identifiers" for each method, then you can stop worrying about const
> methods, constructors, etc. I think this could boil down to one or two
> macros...
Yeah, I think we can reduce everything to:
#define LLDB_INSTRUMENT(...)
\
lldb_private::Instrumenter _instrumenter(LLVM_PRETTY_FUNCTION, __VA_ARGS__);
plus a variant that takes no args. The reason it's not part of this patch is
because it means modifying every single line and I'm lazy^Z^Z^Z^Z not sure when
I'll have the time for that. Maybe I'll just revive lldb-instr locally and have
it generate the new macros for me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117712/new/
https://reviews.llvm.org/D117712
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
