jasonmolenda updated this revision to Diff 408091.
jasonmolenda added a comment.
Fix typeo in comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119602/new/
https://reviews.llvm.org/D119602
Files:
lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Index: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
===================================================================
--- lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -6100,6 +6100,15 @@
if (section->GetFileOffset() == 0 && SectionIsLoadable(section))
return section;
}
+
+ // We may have a binary in the shared cache that has a non-zero
+ // file address for its first segment, traditionally the __TEXT segment.
+ // Search for it by name and return it as our next best guess.
+ SectionSP text_segment_sp =
+ GetSectionList()->FindSectionByName(GetSegmentNameTEXT());
+ if (text_segment_sp.get() && SectionIsLoadable(text_segment_sp.get()))
+ return text_segment_sp.get();
+
return nullptr;
}
Index: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
===================================================================
--- lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -6100,6 +6100,15 @@
if (section->GetFileOffset() == 0 && SectionIsLoadable(section))
return section;
}
+
+ // We may have a binary in the shared cache that has a non-zero
+ // file address for its first segment, traditionally the __TEXT segment.
+ // Search for it by name and return it as our next best guess.
+ SectionSP text_segment_sp =
+ GetSectionList()->FindSectionByName(GetSegmentNameTEXT());
+ if (text_segment_sp.get() && SectionIsLoadable(text_segment_sp.get()))
+ return text_segment_sp.get();
+
return nullptr;
}
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
