jingham added a comment. In D119548#3325999 <https://reviews.llvm.org/D119548#3325999>, @labath wrote:
> Doing it in the common code is a great idea, and it will make the code more > robust. However, instead of "sneaking" the listener through a member > variable, it would be better to pass it through function arguments instead > (normally in the LaunchInfo struct, and as a probably as separate argument > for the last mile). I believe this is what Jim had in mind as well. Yup! > See inline comments for details. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119548/new/ https://reviews.llvm.org/D119548 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
