serge-sans-paille added a comment. In D120195#3333943 <https://reviews.llvm.org/D120195#3333943>, @MaskRay wrote:
> It'd be good to test `-DLLVM_ENABLE_MODULES=on` build. Sure, I'll add that to my local test setup. > Some files get pure new headers. That's expected. It happens a lot when some headers gets a forward declaration instead of a header include when referencing a type. > I still think it is good thing to do it separately. There is a risk that > someone may revert the change if it breaks some build modes. > Splitting the change can be mechanical, perhaps with some git commands to > detect what files get pure addition. I fear I don't have the energy to go at that grain of detail :-/ I'm currently testing with all projects enabled, in release mode. I'll add a setup with ENABLE_MODULE and DEBUG mode to increase the coverage of my pre-commit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120195/new/ https://reviews.llvm.org/D120195 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
