mib created this revision.
mib added reviewers: JDevlieghere, jingham.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch ensures that lldb can automatically load a scripted process
blueprint from a dSYM bundle and launch a scripted process with it.
rdar://74502750
Signed-off-by: Med Ismail Bennani <medismail.benn...@gmail.com>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D121316
Files:
lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
Index: lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
===================================================================
--- lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
+++ lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
@@ -2,7 +2,7 @@
Test python scripted process in lldb
"""
-import os
+import os, shutil
import lldb
from lldbsuite.test.decorators import *
@@ -43,29 +43,39 @@
self.expect('script dir(ScriptedProcess)',
substrs=["launch"])
+ def move_blueprint_to_dsym(self, blueprint_name):
+ blueprint_origin_path = os.path.join(self.getSourceDir(),
blueprint_name)
+ dsym_bundle = self.getBuildArtifact("a.out.dSYM")
+ blueprint_destination_path = os.path.join(dsym_bundle, "Contents",
+ "Resources", "Python")
+ if not os.path.exists(blueprint_destination_path):
+ os.mkdir(blueprint_destination_path)
+
+ blueprint_destination_path = os.path.join(blueprint_destination_path,
"a_out.py")
+ shutil.copy(blueprint_origin_path, blueprint_destination_path)
+
@skipUnlessDarwin
def test_invalid_scripted_register_context(self):
"""Test that we can launch an lldb scripted process with an invalid
Scripted Thread, with invalid register context."""
self.build()
- target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
- self.assertTrue(target, VALID_TARGET)
- log_file = self.getBuildArtifact('thread.log')
- self.runCmd("log enable lldb thread -f " + log_file)
- self.assertTrue(os.path.isfile(log_file))
os.environ['SKIP_SCRIPTED_PROCESS_LAUNCH'] = '1'
def cleanup():
del os.environ["SKIP_SCRIPTED_PROCESS_LAUNCH"]
self.addTearDownHook(cleanup)
- scripted_process_example_relpath = 'invalid_scripted_process.py'
- self.runCmd("command script import " +
os.path.join(self.getSourceDir(),
-
scripted_process_example_relpath))
+ self.runCmd("settings set target.load-script-from-symbol-file true")
+ self.move_blueprint_to_dsym('invalid_scripted_process.py')
+ target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
+ self.assertTrue(target, VALID_TARGET)
+ log_file = self.getBuildArtifact('thread.log')
+ self.runCmd("log enable lldb thread -f " + log_file)
+ self.assertTrue(os.path.isfile(log_file))
launch_info = lldb.SBLaunchInfo(None)
launch_info.SetProcessPluginName("ScriptedProcess")
-
launch_info.SetScriptedProcessClassName("invalid_scripted_process.InvalidScriptedProcess")
+ launch_info.SetScriptedProcessClassName("a_out.InvalidScriptedProcess")
error = lldb.SBError()
process = target.Launch(launch_info, error)
Index: lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
===================================================================
--- lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
+++ lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
@@ -2,7 +2,7 @@
Test python scripted process in lldb
"""
-import os
+import os, shutil
import lldb
from lldbsuite.test.decorators import *
@@ -43,29 +43,39 @@
self.expect('script dir(ScriptedProcess)',
substrs=["launch"])
+ def move_blueprint_to_dsym(self, blueprint_name):
+ blueprint_origin_path = os.path.join(self.getSourceDir(), blueprint_name)
+ dsym_bundle = self.getBuildArtifact("a.out.dSYM")
+ blueprint_destination_path = os.path.join(dsym_bundle, "Contents",
+ "Resources", "Python")
+ if not os.path.exists(blueprint_destination_path):
+ os.mkdir(blueprint_destination_path)
+
+ blueprint_destination_path = os.path.join(blueprint_destination_path, "a_out.py")
+ shutil.copy(blueprint_origin_path, blueprint_destination_path)
+
@skipUnlessDarwin
def test_invalid_scripted_register_context(self):
"""Test that we can launch an lldb scripted process with an invalid
Scripted Thread, with invalid register context."""
self.build()
- target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
- self.assertTrue(target, VALID_TARGET)
- log_file = self.getBuildArtifact('thread.log')
- self.runCmd("log enable lldb thread -f " + log_file)
- self.assertTrue(os.path.isfile(log_file))
os.environ['SKIP_SCRIPTED_PROCESS_LAUNCH'] = '1'
def cleanup():
del os.environ["SKIP_SCRIPTED_PROCESS_LAUNCH"]
self.addTearDownHook(cleanup)
- scripted_process_example_relpath = 'invalid_scripted_process.py'
- self.runCmd("command script import " + os.path.join(self.getSourceDir(),
- scripted_process_example_relpath))
+ self.runCmd("settings set target.load-script-from-symbol-file true")
+ self.move_blueprint_to_dsym('invalid_scripted_process.py')
+ target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
+ self.assertTrue(target, VALID_TARGET)
+ log_file = self.getBuildArtifact('thread.log')
+ self.runCmd("log enable lldb thread -f " + log_file)
+ self.assertTrue(os.path.isfile(log_file))
launch_info = lldb.SBLaunchInfo(None)
launch_info.SetProcessPluginName("ScriptedProcess")
- launch_info.SetScriptedProcessClassName("invalid_scripted_process.InvalidScriptedProcess")
+ launch_info.SetScriptedProcessClassName("a_out.InvalidScriptedProcess")
error = lldb.SBError()
process = target.Launch(launch_info, error)
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
