labath added a comment.

In D121484#3379532 <https://reviews.llvm.org/D121484#3379532>, @JDevlieghere 
wrote:

> In D121484#3378923 <https://reviews.llvm.org/D121484#3378923>, @labath wrote:
>
>> I'm not sure what would be a good way to denote that the new argument 
>> represents the architecture of the host running the debugged process, and 
>> not the one running lldb. This isn't helped by the fact that some of the 
>> darwin platforms use `GetSystemArchitecture` in their implementations 
>> (which, afaict, does mean the lldb host architecture). Having at least a 
>> comment would be nice.
>
> Maybe `platform_host_architecture`

Maybe. Maybe even `process_host_architecture`. But that's quite a mouthful.

> or `platform_architecture`?

That still sounds confusing to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121484/new/

https://reviews.llvm.org/D121484

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to