JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbplatformutil.py:125
def getPlatform():
"""Returns the target platform which the tests are running on."""
----------------
labath wrote:
> I'm not sure if this will work for all apple platforms. Can I assume all of
> them have `configuration.apple_sdk` set?
Only for our "on-device" test suite (i.e. embedded platforms). Seems like the
host case is handled below so that should be fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121605/new/
https://reviews.llvm.org/D121605
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
