zequanwu added inline comments.
================ Comment at: lldb/test/Shell/SymbolFile/NativePDB/local-variables.cpp:8-26 +class B; +class A { +public: + static const A constA; + static A a; + static B b; + int val = 1; ---------------- labath wrote: > zequanwu wrote: > > labath wrote: > > > Would it be possible to put this into a new test case, one that does not > > > require running the binary? If we're able to read global variables > > > without a running process (we can do it with elf+dwarf, but I don't know > > > what's the state with coff+pdb), then we could run this test on > > > non-windows hosts as well (which is great for test coverage). > > Printing doesn't work with any expression involves `::` in NativePDB. So, I > > changed the test to `image lookup -type` which also tries to complete given > > type. > That's cool, but I see the new test still has a `REQUIRES: system-windows`. > Would it be possible to drop that requirement (if not, then why)? This is not necessary. Removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121030/new/ https://reviews.llvm.org/D121030 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits