JDevlieghere added inline comments.
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:320
+
+ std::vector<llvm::StringRef> sorted_keys(keys->GetSize());
+ auto sort_keys = [&sorted_keys](StructuredData::Object *item) -> bool {
----------------
Won't this overflow when you return the example from the summary?
```
{1: "one", 2: "two", 10: "ten"}
```
Would it be easier to populate our own `map<size_t, ObjectSP>` and iterate over
that below?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122429/new/
https://reviews.llvm.org/D122429
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
