[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

Thank you, the names make a lot more sense to me but I am not sure why this was 
originally used either.



================
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:648
+  ValueObjectSP location_sp =
+      l->GetChildMemberWithName(ConstString("__data_"), true);
+  ValueObjectSP size_vo =
----------------
nitpick `/*can_create=*/true` and same for the next two.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124113/new/

https://reviews.llvm.org/D124113

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits