ayermolo updated this revision to Diff 425001.
ayermolo added a comment.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

addressing comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122988/new/

https://reviews.llvm.org/D122988

Files:
  cross-project-tests/lit.cfg.py
  lldb/test/API/lit.cfg.py
  lldb/test/Shell/helper/toolchain.py


Index: lldb/test/Shell/helper/toolchain.py
===================================================================
--- lldb/test/Shell/helper/toolchain.py
+++ lldb/test/Shell/helper/toolchain.py
@@ -140,7 +140,7 @@
 
     # Facebook T92898286
     if config.llvm_test_bolt:
-        host_flags += ['--post-link-optimize', '-fdebug-default-version=4']
+        host_flags += ['--post-link-optimize']
     # End Facebook T92898286
 
     host_flags = ' '.join(host_flags)
Index: lldb/test/API/lit.cfg.py
===================================================================
--- lldb/test/API/lit.cfg.py
+++ lldb/test/API/lit.cfg.py
@@ -205,8 +205,7 @@
 
 # Facebook T92898286
 if is_configured("llvm_test_bolt"):
-    dotest_cmd += ['-E', '"--post-link-optimize"',
-                   '-E', '"-fdebug-default-version=4"']
+    dotest_cmd += ['-E', '"--post-link-optimize"']
 # End Facebook T92898286
 
 if 'lldb-repro-capture' in config.available_features or \
Index: cross-project-tests/lit.cfg.py
===================================================================
--- cross-project-tests/lit.cfg.py
+++ cross-project-tests/lit.cfg.py
@@ -77,7 +77,7 @@
 # Facebook T92898286
 should_test_bolt = get_required_attr(config, "llvm_test_bolt")
 if should_test_bolt:
-    llvm_config.use_clang(required=('clang' in config.llvm_enabled_projects), 
additional_flags=['--post-link-optimize', '-fdebug-default-version=4'])
+    llvm_config.use_clang(required=('clang' in config.llvm_enabled_projects), 
additional_flags=['--post-link-optimize'])
 else:
     llvm_config.use_clang(required=('clang' in config.llvm_enabled_projects))
 # End Facebook T92898286


Index: lldb/test/Shell/helper/toolchain.py
===================================================================
--- lldb/test/Shell/helper/toolchain.py
+++ lldb/test/Shell/helper/toolchain.py
@@ -140,7 +140,7 @@
 
     # Facebook T92898286
     if config.llvm_test_bolt:
-        host_flags += ['--post-link-optimize', '-fdebug-default-version=4']
+        host_flags += ['--post-link-optimize']
     # End Facebook T92898286
 
     host_flags = ' '.join(host_flags)
Index: lldb/test/API/lit.cfg.py
===================================================================
--- lldb/test/API/lit.cfg.py
+++ lldb/test/API/lit.cfg.py
@@ -205,8 +205,7 @@
 
 # Facebook T92898286
 if is_configured("llvm_test_bolt"):
-    dotest_cmd += ['-E', '"--post-link-optimize"',
-                   '-E', '"-fdebug-default-version=4"']
+    dotest_cmd += ['-E', '"--post-link-optimize"']
 # End Facebook T92898286
 
 if 'lldb-repro-capture' in config.available_features or \
Index: cross-project-tests/lit.cfg.py
===================================================================
--- cross-project-tests/lit.cfg.py
+++ cross-project-tests/lit.cfg.py
@@ -77,7 +77,7 @@
 # Facebook T92898286
 should_test_bolt = get_required_attr(config, "llvm_test_bolt")
 if should_test_bolt:
-    llvm_config.use_clang(required=('clang' in config.llvm_enabled_projects), additional_flags=['--post-link-optimize', '-fdebug-default-version=4'])
+    llvm_config.use_clang(required=('clang' in config.llvm_enabled_projects), additional_flags=['--post-link-optimize'])
 else:
     llvm_config.use_clang(required=('clang' in config.llvm_enabled_projects))
 # End Facebook T92898286
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] [PAT... Alexander Yermolovich via Phabricator via lldb-commits

Reply via email to